Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load word.txt from .caster\filters and documentation update #626

Merged
merged 5 commits into from
Jul 3, 2019
Merged

Load word.txt from .caster\filters and documentation update #626

merged 5 commits into from
Jul 3, 2019

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Jul 2, 2019 •
edited
Loading

Since word.txt represents type of Rule Filter in the documentation it should be loaded from .caster\filters.

Changes and Additions

  • Loadsword.txt in .caster\filters instead of .caster\data
  • Renamed FILTER_WORDS_DEFS_PATH to SIMPLIFIED_FILTER_RULES_PATH to reflect documentation.
  • Renames documentation Rule Filters Simplified to Simplified Filter Rules.
  • Added words.txt to filters/examples
  • Added words.txt to MANIFEST.in include in the PIP package

@LexiconCode LexiconCode added Refactor Restructuring file structure or existing code without changing its external behavior. Filter Rules Issues related to filter rules or simplified filter rules. labels Jul 2, 2019
@LexiconCode LexiconCode self-assigned this Jul 2, 2019
@LexiconCode
Copy link
Member Author

Thoughts on how to notify users of the change word.txt loading from .caster\data to .caster\filters?

@LexiconCode LexiconCode added Documentation Issues related to Documentation Complete Pull request is complete and tested as defined by Contributor labels Jul 2, 2019
@LexiconCode LexiconCode merged commit 6b63e7b into dictation-toolbox:master Jul 3, 2019
@LexiconCode LexiconCode deleted the MoveWord.txt branch July 8, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LexiconCode LexiconCode

Labels
Complete Pull request is complete and tested as defined by Contributor Documentation Issues related to Documentation Filter Rules Issues related to filter rules or simplified filter rules. Refactor Restructuring file structure or existing code without changing its external behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LexiconCode