Caster clipboard commands preserve system clipboard #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexiconCode
added
Enhancement
LexiconCode
changed the title
|
@mrob95 Format your code through yapf https://github.com/synkarius/caster/issues/197 and I'll get this merged. |
LexiconCode
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, saying "duple" would copy the current line to the clipboard, make a new line and then paste. This works, but it replaces whatever is in the clipboard with the line you are duplicating, which can be annoying. This is fairly simply fixed by altering all commands which use the clipboard so that they save and restore the clipboard before and after operations.
Commands like "stoosh/spark five" and "duple" should now no longer replace the normal clipboard, provided what's in the clipboard is only a string. Now that this is done it should be fairly easy to implement the first part of #214.
I've been playing around to get the timings right so that it is completely reliable, but it would be worthwhile someone else testing it to make sure it's working properly.