Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: capacity param #17

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature: capacity param #17

wants to merge 3 commits into from

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Sep 2, 2024

Add capacity parameter to metall_create

bigerl
bigerl requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Change is trivial but I have some other comments that just came up during the review.

src/dice/ffi/metall.h Show resolved Hide resolved
src/dice/ffi/metall.h Outdated Show resolved Hide resolved
src/dice/ffi/metall.h Show resolved Hide resolved
src/dice/ffi/metall.h Show resolved Hide resolved
@liss-h
Copy link
Collaborator Author

liss-h commented Sep 4, 2024

Btw: I'm not sure if we actually want to merge this yet. Considering that Metall's capacity limit feature does not work correctly yet

@liss-h liss-h added the blocked This is blocked by another task label Sep 4, 2024
@liss-h
Copy link
Collaborator Author

liss-h commented Oct 8, 2024

Is now fixed on develop in metall, just need to wait for a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
blocked This is blocked by another task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liss-h @bigerl @Clueliss