-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP/Docker test volumes #307
base: development
Are you sure you want to change the base?
Conversation
Final docker RUN command |
Alright, that technically gets the job done, but it's inelegant. Can you make it check runtime env vars to set |
I intent make a review that today, ok? |
Sounds good |
Had to move ENV to runtime in order for rust to pick it up in Carbonado-Core RuntimeFROM rust:1.69-slim-buster AS runtime ENV CARBONADO_DIR=/data/bitmaskd/carbonado/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we see if CI passes if this is updated against the latest development branch?
Also, I'd like to upgrade to the latest stable version of Rust, 1.71.1.
Hunter,
I will double check but I believe in regards to docker we where at 1.71
Rust , but had issues, that caused us to degrade back to 1.69..
I can pull the latest and rebuild and test.
I was focused on the AWS infrastructure until now, But can double back on
Bitmask Core, tomorrow.
I will be working on Saturday.
Wesley
…On Fri, Aug 18, 2023 at 6:58 AM Hunter Beast ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Can we see if CI passes if this is updated against the latest development
branch?
Also, I'd like to upgrade to the latest stable version of Rust, 1.71.1.
—
Reply to this email directly, view it on GitHub
<#307 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATWG7QTWLHS6UZ42ZCCJNJDXV5RF5ANCNFSM6AAAAAA24YLK5Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Testing the run command against the Dockerfile with:
docker run -d --restart always -p 7060:7070 -v /Applications/bitmask/bitmask-core/target/release:/app -v /var/lib/docker/volumes/my_data_volume:/_data --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.17 -e “CARBONADO_DIR=/data”
the volume mounts allow for updating source code, at the same time, writing to the volume data mount