Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/Docker test volumes #307

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Conversation

rustchain64
Copy link
Collaborator

Testing the run command against the Dockerfile with:

docker run -d --restart always -p 7060:7070 -v /Applications/bitmask/bitmask-core/target/release:/app -v /var/lib/docker/volumes/my_data_volume:/_data --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.17 -e “CARBONADO_DIR=/data”

the volume mounts allow for updating source code, at the same time, writing to the volume data mount

@rustchain64
Copy link
Collaborator Author

Final docker RUN command
THIS WRITES TO /mnt/storage/carbonado-docker
docker run -it --user root --restart always -p 7060:7070 --mount type=bind,source=/mnt/storage/carbonado-docker,target=/tmp/bitmaskd/carbonado --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.0.6.2 -e “CARBONADO_DIR=/data” bash

@cryptoquick
Copy link
Member

Alright, that technically gets the job done, but it's inelegant. Can you make it check runtime env vars to set CARBONADO_DIR to /data/bitmaskd/carbonado/ ? Heck, I think that's fine to set even at compile time.

@cryptoquick cryptoquick added this to the 0.6.2 milestone Aug 2, 2023
@crisdut
Copy link
Member

crisdut commented Aug 2, 2023

I intent make a review that today, ok?

@cryptoquick
Copy link
Member

Sounds good

@rustchain64
Copy link
Collaborator Author

Had to move ENV to runtime in order for rust to pick it up in Carbonado-Core

Runtime

FROM rust:1.69-slim-buster AS runtime

ENV CARBONADO_DIR=/data/bitmaskd/carbonado/

@cryptoquick cryptoquick modified the milestones: 0.6.2, 0.6.3 Aug 4, 2023
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we see if CI passes if this is updated against the latest development branch?

Also, I'd like to upgrade to the latest stable version of Rust, 1.71.1.

@rustchain64
Copy link
Collaborator Author

rustchain64 commented Aug 19, 2023 via email

@josediegorobles josediegorobles modified the milestones: 0.6.3, 0.7.0 Aug 31, 2023
@cryptoquick cryptoquick modified the milestones: 0.7.0, 0.7.1 Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants