[MRG] usesourmash prefetch from sourmash v4.1.0
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass testing -- |
ctb
changed the title
sourmash prefetch codesourmash prefetch from sourmash v4.1.0
|
Ready for review and merge, @bluegenes! |
|
ping @taylorreiter @bluegenes for a quick review :) |
bluegenes
approved these changes
May 18, 2021
|
yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update genome-grist to use the
sourmash prefetchcode from sourmash-bio/sourmash#1370, instead of its own implementation.This also updates #76 so that the temporary directory is configurable in the conf files; briefly, you can now specify a list of possible temp directory paths, and they will be tried one at a time. Also removes a possible collision problem where if two people are working on the same sample on the same system, the first one "wins" the tempdir name; tempdirs no longer collide.
🎉 @bluegenes