-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Knockback #7093
Fix Knockback #7093
Conversation
Are they also to fast for you to turn around? Was it not possible to calculate the arrow direction? |
Would that matter? Isn't it based on your current position, not which way you are facing?
I would agree that using missile velocity (would need to figure out the direction component, I guess?) would be a better solution. |
Maybe player facing direction was a bit inaccurate. It calculates direction using the player occupied tile and monster occupied tile, Which generally is whatever direction the player is facing. |
I only read the description so fare, I was mislead apparently. |
I just revised it to solve the potential edge case in the first post. I will revise the first post as well. |
3c478f9
to
0172d60
Compare
4e488a6
to
b22aef6
Compare
This fixes the problem with knockback. Knockback always pushes monsters in the opposite direction that the monster is facing. This can result in monsters being pushed in the wrong direction if they aren't facing the attacking player/missile.
Melee attacks and Telekinesis will calculate a direction based on the player tile and monster future tile upon initiating knockback.
Missiles will calculate a direction based on the missile start tile and monster future tile upon initiating knockback.