deduplicate NPC sell/buy code #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This changes the code a bit: } else {
l -= 4;
}to places that didn't have it before + different value depending on if the item is identified or not, but I don't expect it to cause any problems - stores only sell identified items after all |
Iniquitatis
reviewed
Aug 13, 2023
| @@ -348,6 +348,32 @@ bool StoreAutoPlace(Item &item, bool persistItem) | |||
| return AutoPlaceItemInInventory(player, item, persistItem); | |||
| } | |||
|
|
|||
| void ScrollVendorStore(Item *itemData, int storeLimit, int idx, int selling = true) | |||
There was a problem hiding this comment.
Um, int selling? Why not bool?
There was a problem hiding this comment.
Um,
int selling? Why notbool?
I think I was messing with other parameters and this must've been a leftover, nice catch ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.