Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing reshares count on mobile stream #5693 #5790

Merged
merged 2 commits into from
Mar 17, 2015
Merged

fix missing reshares count on mobile stream #5693 #5790

merged 2 commits into from
Mar 17, 2015

Conversation

visualsayed
Copy link
Contributor

No description provided.

@jhass
Copy link
Member

jhass commented Mar 17, 2015

You're right, the .post_stats seem duplicated, extracting them to a partial like app/views/posts/_post_stats.mobile.haml would be nice.

@visualsayed
Copy link
Contributor Author

Thanks, i will do it.

@visualsayed
Copy link
Contributor Author

@jhass I think it is done. thanks

%li.comment.add_comment_bottom_link_container
- if user_signed_in?
= link_to t('comments.new_comment.comment'), new_post_comment_path(post), :class => 'add_comment_bottom_link btn comment_action inactive'
= render :partial => 'shared/post_stats', :locals => {:post => @post}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the Ruby 1.9 hash style, that we prefer as per our new styleguide: render partial: "shared/post_stats", locals: {post: @post}

@visualsayed
Copy link
Contributor Author

You konw what i thought that you prefere the opposite :-), Right now i will do it.

@visualsayed
Copy link
Contributor Author

done.

@jhass jhass added this to the next-major milestone Mar 17, 2015
@jhass jhass merged commit bf3d903 into diaspora:develop Mar 17, 2015
jhass added a commit that referenced this pull request Mar 17, 2015
…n-mobile-stream

fix missing reshares count on mobile stream #5693
@jhass
Copy link
Member

jhass commented Mar 17, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants