Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-fill publisher on tag page #5442

Merged
merged 2 commits into from
Nov 30, 2014
Merged

Pre-fill publisher on tag page #5442

merged 2 commits into from
Nov 30, 2014

Conversation

svbergerem
Copy link
Member

Supersedes #5314, fixes #4234.

@jhass
Copy link
Member

jhass commented Nov 30, 2014

Looks like that triggered some "Are you sure you want to leave?" dialogs our testsuite doesn't expect.

@svbergerem svbergerem force-pushed the pre-fill-tag-publisher branch from 3391155 to f6fbbbb Compare November 30, 2014 16:14
@svbergerem
Copy link
Member Author

Oh, this also fixes #5425. That's why some tests failed. I added some tests for #5425 and fixed a bug in the invitation form I found while fixing the tests. Let's see if I found all failing tests.

@jhass jhass added this to the next-major milestone Nov 30, 2014
@jhass jhass merged commit f6fbbbb into diaspora:develop Nov 30, 2014
jhass added a commit that referenced this pull request Nov 30, 2014
@jhass
Merge pull request #5442 from svbergerem/pre-fill-tag-publisher
4f8cf0f 
Pre-fill publisher on tag page
@jhass
Copy link
Member

jhass commented Nov 30, 2014

Thank you!

This was referenced Nov 30, 2014
Closed
Closed
@svbergerem svbergerem deleted the pre-fill-tag-publisher branch November 30, 2014 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0.0
Development

Successfully merging this pull request may close these issues.

Automatically add tag if posting from the tag stream
2 participants
@svbergerem @jhass