Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added keyboard shortcut help topic #5100

Merged

Conversation

Faldrian
Copy link
Contributor

@Faldrian Faldrian commented Aug 1, 2014

Added description of implemented keyboard shortcuts to Diasporas integrated help section.

@goobertron
Copy link

That's a good idea to add these. I just have one tiny comment: in English, I'd say:

"c - comment on the current post"

@denschub
Copy link
Member

denschub commented Aug 2, 2014

For the sake of completeness... could you please add tests? We already have tests for help_view.js in spec/javascripts/app/views/help_view_spec.js, should be easy to extend.

@Faldrian
Copy link
Contributor Author

Faldrian commented Aug 3, 2014

I added a test similar to existing tests in spec/javascripts/app/views/help_view_spec.js

keyboard_shortcuts_li2: "k - zum vorigen Beitrag springen"
keyboard_shortcuts_li3: "c - den aktuellen Beitrag kommentieren"
keyboard_shortcuts_li4: "l - den aktuellen Beitrag mit „Gefällt mir“ markieren"
title: "Tastenkürzel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include any other translations than for English and the languages mentioned here: https://wiki.diasporafoundation.org/Contribute_translations#Languages_handled_outside_of_WebTranslateIt

@Faldrian
Copy link
Contributor Author

Faldrian commented Aug 3, 2014

no more non-english translation included

@jhass jhass merged commit d527376 into diaspora:develop Aug 3, 2014
jhass added a commit that referenced this pull request Aug 3, 2014
…tcuts

added keyboard shortcut help topic
@jhass
Copy link
Member

jhass commented Aug 3, 2014

Thank you!

@jhass jhass added this to the next-minor milestone Aug 3, 2014
@Faldrian Faldrian deleted the feature/add_help_keyboard_shortcuts branch August 3, 2014 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants