#4344 Breaks Facebook posting.

[liamn]

The Pull Request #4344 breaks Facebook posting, the users facebook cannot be added to the users account.

Trace is:

NoMethodError (undefined method `[]' for nil:NilClass):
  app/controllers/services_controller.rb:91:in `header_hash'
  app/controllers/services_controller.rb:60:in `abort_if_read_only_access'
  lib/rack/chrome_frame.rb:39:in `call'
  lib/unicorn_killer.rb:35:in `call' 

[oliverbarnes]

I'll look into it. If possible, would you add a breaking spec replicating it please?

[oliverbarnes]

@liamn please let me know if you still get this issue

[liamn]

Facebook's now working, but Twitter is broken now. - I get to the screen where I can authorise the application to use my twitter account, and after authorising it I get a 500.

[oliverbarnes]

Sweet hahah... on it

On Thu, Aug 8, 2013 at 5:00 AM, Liam Nicholson [email protected]:

Facebook's now working, but Twitter is broken now. - I get to the screen
where I can authorise the application to use my twitter account, and after
authorising it I get a 500.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4361#issuecomment-22313688
.

[oliverbarnes]

@liamn can you send me the logs/stack trace please? I'm setting things up to manually test this (I know, shame on me for not having done it before), but while I do it the log might help

[oliverbarnes]

@MrZyx is it possible to test this locally? I just tried creating a twitter app on dev.twitter, but it doesn't like localhost, unlike Facebook apps.

[jhass]

I don't think so :/ Well you could setup DynDNS and all that.

[oliverbarnes]

ok... heroku time :)

On Thu, Aug 8, 2013 at 2:27 PM, Jonne Haß [email protected] wrote:

I don't think so :/

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4361#issuecomment-22348932
.

[liamn]

Trace:

Completed 500 Internal Server Error in 10ms

NoMethodError (undefined method `[]' for #<OAuth::AccessToken:0x000000076ad040>):
  app/controllers/services_controller.rb:100:in `twitter_header_present?'
  app/controllers/services_controller.rb:94:in `twitter_header'
  app/controllers/services_controller.rb:59:in `abort_if_read_only_access'
  lib/rack/chrome_frame.rb:39:in `call'
  lib/unicorn_killer.rb:35:in `call' 

[oliverbarnes]

@liamn would you please test this fix? I deployed it and got the correct message when trying to add twitter without write access. When testing facebook I'm getting a oauth error ("missing client id"), but it might be because the facebook app I created isn't yet properly working, so it'd be good to check with yours.

@MrZyx not ready to merge yet, I'm just waiting on manual tests being fully done to fix breaking specs

[oliverbarnes]

also just tested with read-write access, and it's working

[oliverbarnes]

just fixed the tests. what's left is testing facebook manually. I still have the missing client id issue, so @liamn if you can confirm it works on your end, then it's something with my facebook app, and we can close this issue

[liamn]

I've already confirmed on your pull request, but yeah, everything is working here so it must be your Facebook app.

[oliverbarnes]

yeah, I had SERVICES_FACEBOOK_KEY instead of SERVICES_FACEBOOK_APP_ID in my env