sidecarset forbid updating of sidecar container name (openkruise#937)

Signed-off-by: xiehui <[email protected]> Signed-off-by: Liu Zhenwei <[email protected]>
diannaowa · Sep 14, 2022 · 4ef089c · 4ef089c
1 parent b18144f
commit 4ef089c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/webhook/sidecarset/validating/sidecarset_create_update_handler.go b/pkg/webhook/sidecarset/validating/sidecarset_create_update_handler.go
@@ -249,6 +249,9 @@ func validateSidecarContainerConflict(newContainers, oldContainers []appsv1alpha
 				allErrs = append(allErrs, field.Invalid(fldPath.Child("upgradeStrategy").Child("upgradeType"),
 					container.Name, fmt.Sprintf("container %v upgradeType is immutable", container.Name)))
 			}
+		} else {
+			allErrs = append(allErrs, field.Invalid(fldPath.Child("name"),
+				container.Name, fmt.Sprintf("container %v is not found", container.Name)))
 		}
 	}