Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EU law example to dashboard #867

Merged
merged 14 commits into from
Oct 23, 2024
Merged

Add EU law example to dashboard #867

merged 14 commits into from
Oct 23, 2024

Conversation

laurasootes
Copy link
Contributor

This PR adds the example from the EU law text classification notebook to the dashboard. The example is only available for LIME (as in the notebook). In the dashboard, the user can select one of the 5 example sentences that are also in the notebook.

Following the notebook, I added the functions that are specific to this example to the models utils. Adding this example also required two additional imports for the dashboard installation
Additionally, I added “number of samples” as an adjustable LIME parameter in the dashboard, as it is required by

Two comments on this example:

  • the example takes very long to run, due to the feature calculation. As far as I understand, it is required to use a large number of samples to get a meaningful result (2000), which simply takes long to calculate.
  • The default sentence gives a significant visualisation. However, other example sentences I tried do not really give a result.

@elboyran
Copy link
Contributor

@laurasootes, the dashboard tests are failing.
I will review your PR (a very quick job, great!) when it's all green, and we can merge it then right away.

@laurasootes
Copy link
Contributor Author

@elboyran the dashboard tests pass again :)

@elboyran elboyran requested a review from cwmeijer October 23, 2024 08:37
@elboyran
Copy link
Contributor

Unfortunately, I cannot make it run on my machine. I installed missing packages and still cannot find the trained model, despite me putting it there explicitly :-( I hope @cwmeijer will be able to review it.

@elboyran elboyran removed their request for review October 23, 2024 09:16
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@cwmeijer
Copy link
Member

Unfortunately, I cannot make it run on my machine. I installed missing packages and still cannot find the trained model, despite me putting it there explicitly :-( I hope @cwmeijer will be able to review it.

It worked for me. I ran:

pip install -e .[dashboard,dev,text]
dianna-dashboard

@cwmeijer cwmeijer merged commit 4500fac into main Oct 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants