-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: gateway: Reconnect after heartbeat misses #324
Comments
660d989 introduced a regression. |
diamondburned
added a commit
that referenced
this issue
Apr 14, 2022
This commit adds ws.Handler.LastAcknowledgedBeat to allow ws.Gateway to monitor whether or not the server is still reachable. It fixes #324.
diamondburned
added a commit
that referenced
this issue
Apr 14, 2022
This commit adds ws.Handler.LastAcknowledgedBeat to allow ws.Gateway to monitor whether or not the server is still reachable. It fixes #324.
diamondburned
added a commit
that referenced
this issue
Apr 18, 2022
This commit adds ws.Handler.LastAcknowledgedBeat to allow ws.Gateway to monitor whether or not the server is still reachable. It fixes #324.
diamondburned
added a commit
that referenced
this issue
May 11, 2022
This commit adds ws.Handler.LastAcknowledgedBeat to allow ws.Gateway to monitor whether or not the server is still reachable. It fixes #324.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the gateway does not try to reconnect if it detects that the gateway's last heartbeat ACK was behind time. This is an issue when the computer is suspended for a long period of time, but it might also be an issue in machines with spotty network conditions.
Ideally,
utils/ws
should handle the check, so we can have something like:or
The first method wouldn't require re-locking the state mutex after each loop iteration, so it seems like the better solution to me. Overloading the return type might be kind of weird, though.
The text was updated successfully, but these errors were encountered: