Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Close button for Sub Issue Components Not Closing In Mobile Devices #24 #28

Conversation

sarthakmishra459
Copy link

As the card components were not closing I have added a close button to fix the same. Used Redux Toolkit to preserve the changes throughout all components and ensure smooth functioning and consistent state handling. Next I will work upon improving the responsiveness in mobile devices.
Button Added

Copy link

vercel bot commented May 11, 2024

@sarthakmishra459 is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel.

A member of the Team first needs to authorize it.

@sarthakmishra459 sarthakmishra459 changed the title "Added Close button for Sub Issue Components Not Closing In Mobile Devices #24" Added Close button for Sub Issue Components Not Closing In Mobile Devices #24 May 11, 2024
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextdraw ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 4:47pm

Copy link
Owner

@dhruvpatidar359 dhruvpatidar359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you code has breaked some functionaliy for giving properties to the shapes . Have a look

20240512_071837.mp4

What i suggest you to think of a new kind of UI style in mobile devices . Let's say the properties pannel comes at the button in the form of button when you want to change the properties you click that button and it opens some thing like that .

Try to make a UI first and show me , then we will proceed on this . Remember this is a good issue and requires some sort of Complex UI work .

Copy link
Owner

@dhruvpatidar359 dhruvpatidar359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still i think there is problem with the property , you can see here.
When you draw a shape , it works and if you close the property tab ,it disappears for forever and we can't use it , until and unless we make a new shape .

20240512_104435.mp4

Copy link
Owner

@dhruvpatidar359 dhruvpatidar359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may you please update your branch to latest . Also the font of the text is not applying please check one time .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants