Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nan to 2.x #42

Closed
wants to merge 2 commits into from
Closed

Upgrade nan to 2.x #42

wants to merge 2 commits into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Aug 31, 2015

This switches nan to 2.x. Mostly find/replace to switch to the namespaced function names and to append all the .ToLocalChecked calls. Using [email protected] means that it should be compatible with both iojs 3.x and the upcoming node 4.0.0.

Tested (all on OSX):

  • nvm use 0.8 && npm i && npm test
  • nvm use 0.10 && npm i && npm test
  • nvm use iojs-v1 && npm i && npm test
  • nvm use iojs-v2 && npm i && npm test
  • nvm use iojs-v3 && npm i && npm test

Also tested running an actual testium integration test suite on 0.10 and iojs v2 against this package and it passed. Which ran on a Linux box.

@jkrems jkrems changed the title Upgrade nan to 2.x [WIP] Upgrade nan to 2.x Aug 31, 2015
@jkrems jkrems changed the title [WIP] Upgrade nan to 2.x Upgrade nan to 2.x Aug 31, 2015
@dhruvbird
Copy link
Owner

Any chance you can bump up the version number so that I can publish a new npm.
Thx!
Also, update contributors list.

@jkrems
Copy link
Contributor Author

jkrems commented Sep 1, 2015

Will do. I'm also about to give it some (limited) testing on Linux. Just to make sure. :)

@jkrems
Copy link
Contributor Author

jkrems commented Sep 1, 2015

Done: Bumped the version. Contributors already had my name.

@jkrems
Copy link
Contributor Author

jkrems commented Sep 8, 2015

@dhruvbird Sorry for the ping - node 4.0.0 is imminent. Do you have an estimate when this will be released? :)

@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@rjyamada
Copy link

rjyamada commented Oct 7, 2015

@dhruvbird any idea when this will be released?

@ghost
Copy link

ghost commented Oct 9, 2015

bump http-sync and node 4 should be besties! Could you merge & publish? 😃

@quasipedia
Copy link

bump :)

@paraplexed
Copy link

bump

@orzFly
Copy link

orzFly commented Nov 8, 2015

bump ;)

@NameFILIP
Copy link

will this be merged?

@spoon1312
Copy link

any update on this ?

@archgrove
Copy link

Another ping to beg for merge.

@fernandopasik
Copy link

this is really needed!!

@tstordyallison
Copy link

Any update on this one?!

@jkrems
Copy link
Contributor Author

jkrems commented Apr 9, 2019

It doesn't look like the maintainer of this package has been active in the past year. So I'm going to go ahead and close this. If anybody needs this, the most likely path to success would be to fork and publish.

@jkrems jkrems closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.