-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nan to 2.x #42
Conversation
Any chance you can bump up the version number so that I can publish a new npm. |
Will do. I'm also about to give it some (limited) testing on Linux. Just to make sure. :) |
Done: Bumped the version. Contributors already had my name. |
@dhruvbird Sorry for the ping - node 4.0.0 is imminent. Do you have an estimate when this will be released? :) |
Adding to the list: nodejs/node#2798. |
@dhruvbird any idea when this will be released? |
bump http-sync and node 4 should be besties! Could you merge & publish? 😃 |
bump :) |
bump |
bump ;) |
will this be merged? |
any update on this ? |
Another ping to beg for merge. |
this is really needed!! |
Any update on this one?! |
It doesn't look like the maintainer of this package has been active in the past year. So I'm going to go ahead and close this. If anybody needs this, the most likely path to success would be to fork and publish. |
This switches
nan
to 2.x. Mostly find/replace to switch to the namespaced function names and to append all the.ToLocalChecked
calls. Using[email protected]
means that it should be compatible with both iojs 3.x and the upcoming node 4.0.0.Tested (all on OSX):
nvm use 0.8 && npm i && npm test
nvm use 0.10 && npm i && npm test
nvm use iojs-v1 && npm i && npm test
nvm use iojs-v2 && npm i && npm test
nvm use iojs-v3 && npm i && npm test
Also tested running an actual testium integration test suite on 0.10 and iojs v2 against this package and it passed. Which ran on a Linux box.