network-score: Updates to match specs of ONDC #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreevatsa N <[email protected]>
amarts
reviewed
Apr 8, 2024
There was a problem hiding this comment.
LGTM
I am in dual mind to add entity_name in the chain as entity_id is already present. Can we remove that? @smohan-dw any thoughts?
This change is happening due to the API changes requested on the confidex side.
|
@vatsa287 also, whenever the |
Ack, will change to |
Signed-off-by: Shreevatsa N <[email protected]>
Signed-off-by: Shreevatsa N <[email protected]>
vatsa287
changed the title
smohan-dw
reviewed
Apr 8, 2024
runtime/src/lib.rs
Outdated
| @@ -127,7 +127,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("cord"), | |||
| impl_name: create_runtime_str!("dhiway-cord"), | |||
| authoring_version: 0, | |||
| spec_version: 9100, | |||
| spec_version: 9105, | |||
There was a problem hiding this comment.
Make it 9200, which stands for 0.9.2
smohan-dw
previously approved these changes
Apr 8, 2024
Signed-off-by: Shreevatsa N <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #411