Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] Chain-Space: Add tests for TypeCapacityOverflow #284

Open
3 tasks
vatsa287 opened this issue Feb 5, 2024 · 6 comments · May be fixed by #550
Open
3 tasks

[C4GT] Chain-Space: Add tests for TypeCapacityOverflow #284

vatsa287 opened this issue Feb 5, 2024 · 6 comments · May be fixed by #550
Assignees
@Vaibhavsahu2810
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 5, 2024 •
edited
Loading

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-chain-space after adding it in the code.

Goals

  • Add tests for TypeCapacityOverflow for pallet/chain-space

Expected Outcome

  • Test should assert for TypeCapacityOverflow being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: creating_a_duplicate_space_should_fail which validates error code SpaceAlreadyAnchored

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]
@amarts amarts added the good first issue Good for newcomers label Feb 6, 2024
@chandra-pro
Copy link

heyy @vatsa287 This is Chandramani and I am intrested to take this issue as I am learning Rust and have already contributed in Code4Good 2023 program.
Could you please help me understanidng this project

@chandra-pro
Copy link

@vatsa287 , @amarts can you please give me a brief about this project and what actually I have to do..

@Sohajawdekar
Copy link

Hey @vatsa287 !
I am interested in contributing to this project and reviewed the prerequisites and code. Can you please assign this issue to me ?

Aloneking789 added a commit to Aloneking789/cord that referenced this issue Mar 25, 2024
@Aloneking789
tests.rs
e271385 
FIXES dhiway#284 
We're creating a new test function create_space_should_fail_type_capacity_overflow.
We set up the necessary variables such as creator, author, capacity, etc.
We first create spaces up to the specified capacity.
@Aloneking789 Aloneking789 mentioned this issue Mar 25, 2024
Closed
@Aloneking789
Copy link

The issue is still open i am making a pull request.

@VedantKhairnar
Copy link

Hello @chandra-pro
Are you working on the issue? Do you need any help? Pease let us know.
Thanks.

@Vaibhavsahu2810
Copy link
Contributor

@vatsa287 should i work on this issue?

Vaibhavsahu2810 added a commit to Vaibhavsahu2810/cord that referenced this issue Dec 28, 2024
@Vaibhavsahu2810
Fixes: dhiway#284 Add test cases for TypeCapacityOverflow error
82ad3c8 
Signed-off-by: Vaibhav <[email protected]>
@Vaibhavsahu2810 Vaibhavsahu2810 linked a pull request Dec 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vaibhavsahu2810 Vaibhavsahu2810

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
7 participants
@amarts @VedantKhairnar @vatsa287 @chandra-pro @Aloneking789 @Sohajawdekar @Vaibhavsahu2810