Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: package/statement: Add function prepareExtrinsic() to return extrinsic and change cord version to latest #182

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

Vikastc
Copy link
Contributor

@Vikastc Vikastc commented Mar 3, 2024

fixes: #180

Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json and yarn.lock changes can come in as a separate PR IMO

package.json Outdated
@@ -68,6 +68,6 @@
"resolutions": {
"typescript": "^5.3.3"
},
"version": "0.9.3-1rc4",
"version": "0.9.3-1r6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, this is not needed now, while making the release we can change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@Vikastc Vikastc force-pushed the prepare-extrinsic branch from af34a00 to fb5def0 Compare March 3, 2024 09:30
@Vikastc Vikastc requested a review from amarts March 3, 2024 09:31
@amarts amarts merged commit 0871e55 into dhiway:develop Mar 3, 2024
1 check passed
@amarts
Copy link
Member

amarts commented Mar 3, 2024

will make a release tomorrow or day after, once we get #184 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move signAndSubmitTx out of the function dispatchRegisterToChain & dispatchRevokeToChain
2 participants