Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generateKeypair moved to package/utils #157

Merged
merged 1 commit into from
Dec 22, 2023
Merged

generateKeypair moved to package/utils #157

merged 1 commit into from
Dec 22, 2023

Conversation

amarts
Copy link
Member

@amarts amarts commented Dec 21, 2023

  • This helps signing as per DID Uri.
  • Every operation requiring the private keys to be used for signing, hence require a library function.

adi-a11y
adi-a11y approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@adi-a11y adi-a11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarts amarts merged commit 0b196b6 into dhiway:develop Dec 22, 2023
1 check passed
@amarts amarts deleted the moveGenerateKey_to_util_pkg branch December 22, 2023 08:01
@amarts amarts mentioned this pull request Dec 25, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal6792 ujjwal6792 ujjwal6792 approved these changes

@adi-a11y adi-a11y adi-a11y approved these changes

@smohan-dw smohan-dw Awaiting requested review from smohan-dw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarts @adi-a11y @ujjwal6792