chore(cli app scripts): update to 5.7.2 and adjust related files

[Mohammer5]

• Upgraded the @dhis2/cli-app-scripts package to 5.7.0
• Changed build/[es|cjs]/lib.js to ./build/[es|cjs]/index.js
• Added the exports field to all workspaces' `package.json
• Added locale files to sideeffects in the widgets and forms workspaces
• Adjusted the storybook's babel config file
• Figure out if the changes to get the icons library to work again are legit

When running yarn build:icons on master, the following files are being created:

packages/icons/build/es/lib.js
packages/icons/build/cjs/lib.js

When switching to this branch, this does not happen anymore until I added an index.js to the icons' src folder which imports ./react/index.js

[cypress]

---

Test summary

502 • 0 • 0 • 0

---

Run details

Project	ui
Status	Passed
Commit	b77d6c3
Started	Mar 5, 2021 2:00 PM
Ended	Mar 5, 2021 2:04 PM
Duration	04:09 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 87

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[amcgee]

Code change LGTM, obviously tests need to pass and I haven't tried running this locally

[varl]

There is a funky test failure in the Transfer's LeftSide component when it imports the background color. I can resolve it manually, so it's definitely there, but for some reason loading the CJS fails in the test.

[varl]

Ah, I see:

./core/src/AlertBar/AlertBar.stories.js: Error: styled-jsx/css: if you are getting this error it means that your css tagged template literals were not transpiled.

[Mohammer5]

There is a funky test failure in the Transfer's LeftSide component when it imports the background color. I can resolve it manually, so it's definitely there, but for some reason loading the CJS fails in the test.

I've seen that one as well. But I can't figure out why it's happening. It's never failed before, the imports seem correct. I was able to get the test to succeed again by renaming that file, run the test and then rename the file back to its original name. The second time the error occurred, I wasn't able to do anything about it (even after deleting all node module folders, clearing jest's and yarn's caches and then installing the packages again)

[varl]

The test is failing because we now copy all the source files to the build directory, and Jest is very eager when it comes to finding and running tests, so it also runs them from the build/ directory. The tests don't necessarily work in their transpiled variants, so we get problems.

This fixes the test command in app-scripts: dhis2/app-platform#521

[varl]

There is some strange interactions going on between Storybook's Webpack and Bable setup, where some sources are imported through the entry-points in the build folder, and some are imported through the src folder. The build imports are already transpiled so they work properly, but the src imports somehow end up not being transpiled by Storybook's Webpack+Bable combo, even after overriding them.

When I swap out e.g. import { Button } from './Button.js' to import { Button } from '@dhis2/ui' in Button.stories.js, Storybook starts working correctly.

[Mohammer5]

When I swap out e.g. import { Button } from './Button.js' to import { Button } from '@dhis2/ui' in Button.stories.js, Storybook starts working correctly.

In my opinion importing from the built library is the actual correct implementation, because it doesn't require that storybook needs to be aware of any build steps required to get the component to work.
On the other side I can see why it's handy to just import the component via the relative path..
Given the current situation, I think I'd prefer changing the imports in all stories, if you agree (importing from '@dhis2/...')

EDIT: Good find, btw

[varl]

@Mohammer5 That brings us to the next step.

Nothing in subpackages is allowed to import @dhis2/ui. We can either ESLint ignore in every Storybook file, or move the Storybook stuff outside of core.

[varl]

Alright, I figured out a way to override the Storybook Babel configuration with our necessary customization.

[dhis2-bot]

🎉 This PR is included in version 6.5.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀