fix(alertbar): skip init on component update #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
fix-alertbar-infinite-loop
branch
from
42f2b68 to
b08c8a9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This comment has been minimized.
This comment has been minimized.
ghost
marked this pull request as draft
ghost
force-pushed
the
fix-alertbar-infinite-loop
branch
from
b08c8a9 to
b250d42
Compare
fixes an infinite loop caused by an unconditional setstate on component updates
ghost
force-pushed
the
fix-alertbar-infinite-loop
branch
from
b250d42 to
a6171a4
Compare
ghost
marked this pull request as ready for review
Thanks! Thanks for the help debugging! |
|
🎉 This PR is included in version 5.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an infinite loop caused by an unconditional setstate on component updates. It doesn't seem necessary to re-run init when the props are updated anyway. The core problem was the setState in the
show()method, which was called byinit(), which was run on every update (or more precisely, when state was the same as the previous state).I've tried to stick to the existing code as much as possible. Starting out with the
.visibleclass could maybe be refactored to starting out without a class, and then hiding when a.hidingclass is added instead for example. But I figured that those kinds of more elaborate changes were out of scope for this PR.Closes #299