Skip to content

Commit

Permalink
chore: update modal confirmation text
Browse files Browse the repository at this point in the history
  • Loading branch information
ismay committed Jan 2, 2024
1 parent 049cbdd commit 35b74ac
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 17 deletions.
2 changes: 1 addition & 1 deletion cypress/integration/add-job/back-to-all-jobs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ Feature: Users should be able to navigate back to the list route
Scenario: User clicks the cancel button after editing the form
Given the user has edited the form
When the user clicks the cancel button
Then the user will be asked if they want to discard the form
Then the user will be asked if they want to discard their changes
6 changes: 4 additions & 2 deletions cypress/integration/add-job/back-to-all-jobs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Then('the list route will be loaded', () => {
cy.findByRole('heading', { name: 'Scheduled jobs' }).should('exist')
})

Then('the user will be asked if they want to discard the form', () => {
cy.findByText('Are you sure you want to discard this form?').should('exist')
Then('the user will be asked if they want to discard their changes', () => {
cy.findByText('Are you sure you want to discard your changes?').should(
'exist'
)
})
2 changes: 1 addition & 1 deletion cypress/integration/add-queue/back-to-all-jobs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ Feature: Users should be able to navigate back to the list route
Scenario: User clicks the cancel button after editing the form
Given the user has edited the form
When the user clicks the cancel button
Then the user will be asked if they want to discard the form
Then the user will be asked if they want to discard their changes
6 changes: 4 additions & 2 deletions cypress/integration/add-queue/back-to-all-jobs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Then('the list route will be loaded', () => {
cy.findByRole('heading', { name: 'Scheduled jobs' }).should('exist')
})

Then('the user will be asked if they want to discard the form', () => {
cy.findByText('Are you sure you want to discard this form?').should('exist')
Then('the user will be asked if they want to discard their changes', () => {
cy.findByText('Are you sure you want to discard your changes?').should(
'exist'
)
})
2 changes: 1 addition & 1 deletion cypress/integration/edit-job/back-to-all-jobs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ Feature: Users should be able to navigate back to the list route
Scenario: User clicks the cancel button after editing the form
Given the user has edited the form
When the user clicks the cancel button
Then the user will be asked if they want to discard the form
Then the user will be asked if they want to discard their changes
6 changes: 4 additions & 2 deletions cypress/integration/edit-job/back-to-all-jobs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Then('the list route will be loaded', () => {
cy.findByRole('heading', { name: 'Scheduled jobs' }).should('exist')
})

Then('the user will be asked if they want to discard the form', () => {
cy.findByText('Are you sure you want to discard this form?').should('exist')
Then('the user will be asked if they want to discard their changes', () => {
cy.findByText('Are you sure you want to discard your changes?').should(
'exist'
)
})
2 changes: 1 addition & 1 deletion cypress/integration/edit-queue/back-to-all-jobs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ Feature: Users should be able to navigate back to the list route
Scenario: User clicks the cancel button after editing the form
Given the user has edited the form
When the user clicks the cancel button
Then the user will be asked if they want to discard the form
Then the user will be asked if they want to discard their changes
6 changes: 4 additions & 2 deletions cypress/integration/edit-queue/back-to-all-jobs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ Then('the list route will be loaded', () => {
cy.findByRole('heading', { name: 'Scheduled jobs' }).should('exist')
})

Then('the user will be asked if they want to discard the form', () => {
cy.findByText('Are you sure you want to discard this form?').should('exist')
Then('the user will be asked if they want to discard their changes', () => {
cy.findByText('Are you sure you want to discard your changes?').should(
'exist'
)
})
8 changes: 4 additions & 4 deletions i18n/en.pot
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1)\n"
"POT-Creation-Date: 2023-11-29T10:47:23.653Z\n"
"PO-Revision-Date: 2023-11-29T10:47:23.656Z\n"
"POT-Creation-Date: 2024-01-02T14:28:02.554Z\n"
"PO-Revision-Date: 2024-01-02T14:28:02.554Z\n"

msgid "Something went wrong"
msgstr "Something went wrong"
Expand Down Expand Up @@ -237,8 +237,8 @@ msgstr "Are you sure you want to delete this job?"
msgid "Are you sure you want to delete this queue?"
msgstr "Are you sure you want to delete this queue?"

msgid "Are you sure you want to discard this form?"
msgstr "Are you sure you want to discard this form?"
msgid "Are you sure you want to discard your changes?"
msgstr "Are you sure you want to discard your changes?"

msgid "Discard"
msgstr "Discard"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Modal/DiscardFormModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import history from '../../services/history'
const DiscardFormModal = ({ hideModal }) => (
<Modal open small onClose={hideModal}>
<ModalContent>
{i18n.t('Are you sure you want to discard this form?')}
{i18n.t('Are you sure you want to discard your changes?')}
</ModalContent>
<ModalActions>
<ButtonStrip end>
Expand Down

0 comments on commit 35b74ac

Please sign in to comment.