fix: make sure map is present before removing layers and source (#436)

dhis2 · Feb 7, 2022 · 58c6cd1 · 58c6cd1
1 parent d742735
commit 58c6cd1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/src/layers/Layer.js b/src/layers/Layer.js
@@ -79,17 +79,19 @@ class Layer extends Evented {
 
         this.onRemove()
 
-        layers.forEach(layer => {
-            if (mapgl.getLayer(layer.id)) {
-                mapgl.removeLayer(layer.id)
-            }
-        })
-
-        Object.keys(source).forEach(id => {
-            if (mapgl.getSource(id)) {
-                mapgl.removeSource(id)
-            }
-        })
+        if (mapgl) {
+            layers.forEach(layer => {
+                if (mapgl.getLayer(layer.id)) {
+                    mapgl.removeLayer(layer.id)
+                }
+            })
+
+            Object.keys(source).forEach(id => {
+                if (mapgl.getSource(id)) {
+                    mapgl.removeSource(id)
+                }
+            })
+        }
 
         if (onClick) {
             this.off('click', onClick)

diff --git a/src/layers/VectorStyle.js b/src/layers/VectorStyle.js
@@ -37,7 +37,9 @@ class VectorStyle extends Evented {
     // Remove vector style from map, reset to default map style
     async removeFrom() {
         const glyphs = this._map._glyphs
-        await this.toggleVectorStyle(false, mapStyle({ glyphs }))
+        if (this._map.getMapGL()) {
+            await this.toggleVectorStyle(false, mapStyle({ glyphs }))
+        }
     }
 
     // Set map style, resolves promise when map is ready for other layers