Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear dimension items array when filter is changed #263

Merged
merged 2 commits into from
Nov 18, 2019
Merged

fix: clear dimension items array when filter is changed #263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb299ff
Clear dimension array when filter is changed
turban Nov 14, 2019
478e0ee
Variable name change
turban Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/dimensions/DimensionFilterRow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class DimensionFilterRow extends Component {
<div className={classes.container}>
<DimensionSelect
dimension={dimension}
onChange={dimension => this.onChange(dimension.id, items)}
onChange={dimension => this.onChange(dimension.id)}
turban marked this conversation as resolved.
Show resolved Hide resolved
/>
<DimensionItemsSelect
dimension={dimension}
Expand Down