Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit fonts and images from precache #2523

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Mar 13, 2023

This will stop all the thousands of pbf files from being downloaded.
Also, other platform dependencies were upgraded to keep consistent versions.

Waiting on this PR: dhis2/app-platform#793

@jenniferarnesen jenniferarnesen marked this pull request as draft March 13, 2023 09:58
@cypress
Copy link

cypress bot commented Mar 13, 2023

Passing run #1820 ↗︎

0 31 22 0 Flakiness 0

Details:

fix: upgrade dependencies
Project: maps Commit: 822d206d75
Status: Passed Duration: 04:19 💡
Started: Mar 13, 2023 11:07 AM Ended: Mar 13, 2023 11:11 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on debug/dev and confirmed that fonts and images aren't precached any more 🙂

@jenniferarnesen jenniferarnesen marked this pull request as ready for review March 13, 2023 11:58
@jenniferarnesen jenniferarnesen merged commit ffd0e4a into master Mar 13, 2023
@jenniferarnesen jenniferarnesen deleted the fix/globsToOmitFromPrecache branch March 13, 2023 11:58
dhis2-bot added a commit that referenced this pull request Mar 13, 2023
## [1.30.7](v1.30.6...v1.30.7) (2023-03-13)

### Bug Fixes

* omit fonts and images from precache ([#2523](#2523)) ([ffd0e4a](ffd0e4a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.30.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants