fix: improved facility symbol handling (DHIS2-14438) #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jenniferarnesen
approved these changes
Jan 16, 2023
dhis2-bot
added a commit
that referenced
this pull request
Jan 16, 2023
## [1.27.6](v1.27.5...v1.27.6) (2023-01-16) ### Bug Fixes * improved facility symbol handling (DHIS2-14438) ([#2423](#2423)) ([2a43892](2a43892))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for SVG symbols for facility layer, and improve the symbol error handling.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-14440 (in dhis2/maps-gl#517)
Fixes: https://dhis2.atlassian.net/browse/DHIS2-14438
If one or more symbols are missing, we will still show the remaining symbols on the map. A warning message about the first symbol missing is shown to the user.
The same error handling as we have for Earth Engine layers was reused. Added support for both critical and warning errors.
Two new methods was added to the Layer class:
After this PR:
