fix: constrasting event stroke and cluster count color #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
turban
changed the title
edoardo
approved these changes
Sep 13, 2021
dhis2-bot
added a commit
that referenced
this pull request
Sep 13, 2021
## [1.13.21](v1.13.20...v1.13.21) (2021-09-13) ### Bug Fixes * constrasting event stroke and cluster count color ([#1861](#1861)) ([65173b5](65173b5))
|
🎉 This PR is included in version 1.13.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a contrasting stroke and cluster count color for events. If the event color is dark, the stroke/vount color will be bright, and opposite. Stroke will only be used for single color maps, not when events that are "styled by data item".
Storke is also added to the legend item, and legend item is added for server cluster (see screenshot below).
Depends on dhis2/maps-gl#398
After this PR:
Before: