feat: pull docs from other repositories #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
kabaros
reviewed
Oct 25, 2023
kabaros
reviewed
Oct 25, 2023
|
|
||
| migrateDocs({ | ||
| repo: 'https://github.com/dhis2/cli-utils-cypress.git', | ||
| branch: 'docs-improve', |
There was a problem hiding this comment.
will these remain as the branch names .. would you not point to master before merging?
There was a problem hiding this comment.
These branches will be removed, so a follow-up PR needs to fix that, but currently they don't work with master, and merging the other repositories first will cause those doc-sites to potentially break from changed links. So it's a 2-step process
kabaros
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in documentation from 5 external sources, and displays them in the sidebar for the docs page. There's also structural changes to the sidebar, and logic changes for the "edit this page" button.