-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display type and definitions for data items in data selector (DHIS2-14774) #3274
Merged
janhenrikoverland
merged 39 commits into
master
from
feat/info-data-item-selector-DHIS2-14774
Jan 9, 2025
Merged
feat: display type and definitions for data items in data selector (DHIS2-14774) #3274
janhenrikoverland
merged 39 commits into
master
from
feat/info-data-item-selector-DHIS2-14774
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3274.data-visualizer.netlify.dhis2.org |
edoardo
changed the title
chore: update analytics to latest build for testing
feat: implement item selector info popover (DHIS2-14774)
Nov 4, 2024
edoardo
force-pushed
the
feat/info-data-item-selector-DHIS2-14774
branch
from
November 8, 2024 14:50
01550b0
to
320b9fa
Compare
edoardo
added
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Nov 12, 2024
Data Visualizer App Run #2986
Run Properties:
|
Project |
Data Visualizer App
|
Branch Review |
feat/info-data-item-selector-DHIS2-14774
|
Run status |
Passed #2986
|
Run duration | 09m 24s |
Commit |
6073966fae ℹ️: Merge 748ecb7865d147934b31ada9ee420fc28aa2ef18 into 03083b05c7280113d0e18b5fc8bf...
|
Committer | Edoardo Sabadelli |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
731
|
View all changes introduced in this branch ↗︎ |
edoardo
removed
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Nov 12, 2024
This is needed for POST requests to the program indicator expression description endpoint to work correctly.
…-selector-DHIS2-14774
Updated screenshots.
edoardo
added
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Dec 20, 2024
edoardo
removed
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Jan 9, 2025
edoardo
changed the title
feat: implement item selector info popover (DHIS2-14774)
feat: display type and definitions for data items in data selector (DHIS2-14774)
Jan 9, 2025
janhenrikoverland
approved these changes
Jan 9, 2025
dhis2-bot
added a commit
that referenced
this pull request
Jan 9, 2025
# [100.9.0](v100.8.8...v100.9.0) (2025-01-09) ### Features * display type and definitions for data items in data selector (DHIS2-14774) ([#3274](#3274)) ([f44897a](f44897a))
🎉 This PR is included in version 100.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14774
Requires dhis2/analytics#1713
Key features
Description
In the data item selector, show a popover with information for each data item
The actual implementation is in
analytics
. Refer to that PR.TODO
Screenshots