Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display type and definitions for data items in data selector (DHIS2-14774) #3274

Merged
merged 39 commits into from
Jan 9, 2025

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Oct 30, 2024

Implements DHIS2-14774

Requires dhis2/analytics#1713


Key features

  1. bump analytics with data item selector info popover feature

Description

In the data item selector, show a popover with information for each data item
The actual implementation is in analytics. Refer to that PR.


TODO

  • Cypress tests
  • Update docs
  • Manual testing

Screenshots

Screenshot 2024-11-21 at 12 03 26
Screenshot 2024-11-21 at 12 03 36
Screenshot 2024-11-21 at 12 03 49

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 30, 2024

🚀 Deployed on https://pr-3274.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2024 14:29 Inactive
@edoardo edoardo changed the title chore: update analytics to latest build for testing feat: implement item selector info popover (DHIS2-14774) Nov 4, 2024
@edoardo edoardo force-pushed the feat/info-data-item-selector-DHIS2-14774 branch from 01550b0 to 320b9fa Compare November 8, 2024 14:50
@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 14:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 11:22 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 12, 2024 08:37 Inactive
@edoardo edoardo added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

Data Visualizer App    Run #2986

Run Properties:  status check passed Passed #2986  •  git commit 6073966fae ℹ️: Merge 748ecb7865d147934b31ada9ee420fc28aa2ef18 into 03083b05c7280113d0e18b5fc8bf...
Project Data Visualizer App
Branch Review feat/info-data-item-selector-DHIS2-14774
Run status status check passed Passed #2986
Run duration 09m 24s
Commit git commit 6073966fae ℹ️: Merge 748ecb7865d147934b31ada9ee420fc28aa2ef18 into 03083b05c7280113d0e18b5fc8bf...
Committer Edoardo Sabadelli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 731
View all changes introduced in this branch ↗︎

@edoardo edoardo removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify November 21, 2024 11:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 21, 2024 11:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 22, 2024 14:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 11:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 13:19 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 26, 2024 15:49 Inactive
@edoardo edoardo marked this pull request as ready for review December 19, 2024 10:40
@dhis2-bot dhis2-bot temporarily deployed to netlify December 19, 2024 10:43 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 19, 2024 15:00 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 19, 2024 15:22 Inactive
@edoardo edoardo added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Dec 20, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify December 20, 2024 15:47 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 2, 2025 07:49 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 6, 2025 13:43 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 7, 2025 14:40 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 9, 2025 10:07 Inactive
@edoardo edoardo removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jan 9, 2025
@edoardo edoardo changed the title feat: implement item selector info popover (DHIS2-14774) feat: display type and definitions for data items in data selector (DHIS2-14774) Jan 9, 2025
@janhenrikoverland janhenrikoverland merged commit f44897a into master Jan 9, 2025
34 checks passed
@janhenrikoverland janhenrikoverland deleted the feat/info-data-item-selector-DHIS2-14774 branch January 9, 2025 12:52
dhis2-bot added a commit that referenced this pull request Jan 9, 2025
# [100.9.0](v100.8.8...v100.9.0) (2025-01-09)

### Features

* display type and definitions for data items in data selector (DHIS2-14774) ([#3274](#3274)) ([f44897a](f44897a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants