Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in tests #244

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix warnings in tests #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../app/src/components/DimensionsPanel/Dialogs/DataDimension/__tests__/DataDimension.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ describe('DataDimension component ', () => {
shallowDataDim = undefined;

api.apiFetchAlternatives = jest.fn().mockResolvedValue({
dimensionItems: [{ id: 'dimId1' }, { id: 'dimId2' }],
dimensionItems: [
{ id: 'dimId1', name: 'dim item 1' },
{ id: 'dimId2', name: 'dim item 2' },
],
nextPage: null,
});
});
Expand Down
148 changes: 0 additions & 148 deletions ...src/components/DimensionsPanel/Dialogs/__tests__/__snapshots__/DialogManager.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,87 +1,5 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`The DialogManager component renders OUDimension content with display:none when previously mounted 1`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={true}
maxWidth="lg"
onClose={[Function]}
open={true}
>
<div
key="ou"
style={
Object {
"display": "block",
}
}
>
<Connect(OrgUnitDimension) />
</div>
<Component>
<Connect(HideButton) />
<Connect(WithStyles(AddToLayoutButton))
dialogId="ou"
/>
</Component>
</Component>
`;

exports[`The DialogManager component renders OUDimension content with display:none when previously mounted 2`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={true}
maxWidth="lg"
onClose={[Function]}
open={false}
>
<div
key="ou"
style={
Object {
"display": "none",
}
}
>
<Connect(OrgUnitDimension) />
</div>
<Component>
<Connect(HideButton) />
</Component>
</Component>
`;

exports[`The DialogManager component renders OUDimension content with display:none when previously mounted 3`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={false}
maxWidth="lg"
onClose={[Function]}
open={true}
>
<div
key="ou"
style={
Object {
"display": "none",
}
}
>
<Connect(OrgUnitDimension) />
</div>
<Connect(DataDimension) />
<Component>
<Connect(HideButton) />
<Connect(WithStyles(AddToLayoutButton))
dialogId="dx"
/>
</Component>
</Component>
`;

exports[`The DialogManager component renders a closed dialog 1`] = `
<Component
data-test="dialog-manager"
Expand All @@ -97,25 +15,6 @@ exports[`The DialogManager component renders a closed dialog 1`] = `
</Component>
`;

exports[`The DialogManager component renders the DataDimension content in dialog 1`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={false}
maxWidth="lg"
onClose={[Function]}
open={true}
>
<Connect(DataDimension) />
<Component>
<Connect(HideButton) />
<Connect(WithStyles(AddToLayoutButton))
dialogId="dx"
/>
</Component>
</Component>
`;

exports[`The DialogManager component renders the DynamicDimension content in dialog 1`] = `
<Component
data-test="dialog-manager"
Expand All @@ -136,50 +35,3 @@ exports[`The DialogManager component renders the DynamicDimension content in dia
</Component>
</Component>
`;

exports[`The DialogManager component renders the OrgUnitDimension content in dialog 1`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={true}
maxWidth="lg"
onClose={[Function]}
open={true}
>
<div
key="ou"
style={
Object {
"display": "block",
}
}
>
<Connect(OrgUnitDimension) />
</div>
<Component>
<Connect(HideButton) />
<Connect(WithStyles(AddToLayoutButton))
dialogId="ou"
/>
</Component>
</Component>
`;

exports[`The DialogManager component renders the PeriodDimension content in dialog 1`] = `
<Component
data-test="dialog-manager"
disableEnforceFocus={true}
keepMounted={false}
maxWidth="lg"
onClose={[Function]}
open={true}
>
<Connect(PeriodDimension) />
<Component>
<Connect(HideButton) />
<Connect(WithStyles(AddToLayoutButton))
dialogId="pe"
/>
</Component>
</Component>
`;
2 changes: 1 addition & 1 deletion packages/app/src/components/DimensionsPanel/List/__tests__/RecommendedIcon.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('The RecommendedIcon component ', () => {
});

it('renders a Tooltip when state anchorEl is not falsy', () => {
recIcon().setState({ anchorEl: true });
recIcon().setState({ anchorEl: {} });
const popper = recIcon().find(Popper);

expect(popper.length).toEqual(1);
Expand Down
Loading