Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: complete translations [v34] #1014

Merged
merged 16 commits into from
May 28, 2020
Merged

fix: complete translations [v34] #1014

merged 16 commits into from
May 28, 2020

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented May 20, 2020 •
edited
Loading

Part of fix for https://jira.dhis2.org/browse/DHIS2-8894

Please give the app a quick test.

Notes:
*Most of the work was simply switching to use functions to return the result of i18n.t.

  • The period selector translations aren't yet in the analytics package (since those strings haven't been synced to transifex yet). But note that since some of the period translations are in DV due to modules/metadata.js, the period dialog appears partially translated.
  • yarn.lock was regenerated due to weird errors that seemed to be due to 3rd party deps (no, nuking node_modules didn't fix the problem)
  • In plugin, the option for noData was removed since analytics now sets the default noData option to be "No data".

Some screenshots:

Note for interpretations that some translations are still missing in the d2-ui-interpretations package. When that is available, then a new PR for DV will be made with the package upgrade.

@jenniferarnesen
Copy link
Collaborator Author

@amcgee This PR encompasses all the changes in #1009.

@jenniferarnesen jenniferarnesen mentioned this pull request May 20, 2020
Closed
@martinkrulltott martinkrulltott changed the title chore: complete translations [v34] fix: complete translations [v34] May 22, 2020
@jenniferarnesen jenniferarnesen mentioned this pull request May 25, 2020
Merged
martinkrulltott
martinkrulltott reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 Will test locally before approving. Only question is the version of the DV plugin (why alpha version?).

packages/app/package.json Outdated Show resolved Hide resolved
@jenniferarnesen jenniferarnesen merged commit 9f087a3 into v34 May 28, 2020
@jenniferarnesen jenniferarnesen deleted the chore/complete-translations-v34 branch May 28, 2020 19:51
@jenniferarnesen jenniferarnesen restored the chore/complete-translations-v34 branch May 28, 2020 21:10
dhis2-bot added a commit that referenced this pull request Jun 2, 2020
@dhis2-bot
chore(release): cut 34.5.2 [skip ci]
584a7aa 
## [34.5.2](v34.5.1...v34.5.2) (2020-06-02)

### Bug Fixes

* **translations:** sync translations from transifex (v34) ([bb15692](bb15692))
* complete translations [v34] ([#1014](#1014)) ([9f087a3](9f087a3))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 34.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jenniferarnesen jenniferarnesen deleted the chore/complete-translations-v34 branch June 6, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcgee amcgee amcgee left review comments

@martinkrulltott martinkrulltott martinkrulltott approved these changes

@janhenrikoverland janhenrikoverland Awaiting requested review from janhenrikoverland

Assignees
No one assigned
Labels
released on @34.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenniferarnesen @dhis2-bot @amcgee @martinkrulltott