-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint): add compat eslint plugin #364
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like another good addition 👍
539a9b3
to
e448da7
Compare
I've changed the approach here slightly. The We could remove opera mini from our browserslist if we don't support it, and otherwise we should ship a promise polyfill. Until then, I'll leave this rule on warn. Once we've decided what we want to do about the above, we could move the rule to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have confidence in browser compatibility!
We should probably exclude Opera Mini, otherwise we will definitely need the polyfill
Hi! Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open. Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖 |
Automatically closing due to lack of activity. 🤖 |
This adds https://www.npmjs.com/package/eslint-plugin-compat. This plugin checks the js APIs you're using against your browserslist. It'll warn you when you're using js APIs that aren't supported by your target audience.
As long as we're sticking to stable browser features, and not polyfilling with babel to features that haven't shipped with browsers yet, this is a useful plugin to have (and even if we do it can be useful, just means that we need to define the polyfills we ship).