feat: parse pluginType from d2 config to add to manifest.webapp #849
Conversation
There was a problem hiding this comment.
looks good!
Do you think it might be appropriate to do convert pluginType to upper case, so that we don't end up people with uploading variants like dashboard or Dashboard, which will then be unique types? I don't think there's a good reason to allow for case-sensitive definition of plugin types, and doing the conversion on manifest generation would probably prevent some unintended errors.
|
Good call... I think I'll implement that as a validation step, so that the user gets feedback that it should be in all caps, so they know what to expect if they try to filter for it -- Update: |
# [11.4.0](v11.3.1...v11.4.0) (2024-06-04) ### Features * parse pluginType from d2 config to add to manifest.webapp ([#849](#849)) ([c1dae23](c1dae23))
|
🎉 This PR is included in version 11.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [12.0.0-alpha.2](v12.0.0-alpha.1...v12.0.0-alpha.2) (2024-06-20) ### Bug Fixes * clean up for plugins [LIBS-620] ([#851](#851)) ([13af3b5](13af3b5)) * do not encode username, password ([#852](#852)) ([2fb4272](2fb4272)) * don't start plugins for apps without a plugin entrypoint ([#850](#850)) ([a89d4cf](a89d4cf)) ### Features * parse pluginType from d2 config to add to manifest.webapp ([#849](#849)) ([c1dae23](c1dae23)) * start plugin and app separately [LIBS-391] [LIBS-392] ([#848](#848)) ([82003e7](82003e7))
|
🎉 This PR is included in version 12.0.0-alpha.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Reads a
pluginTypestring fromd2.config.jsand adds it tomanifest.webappasplugin_type(see the backend code that parsesmanifest.webapp)pluginType: 'DASHBOARD'shows up in dashboard app list:pluginType: 'CAPTURE'doesn't show up in dashboard app list:config:
