Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pwa): avoid crashing when SW is not available [LIBS-499] #807

Merged
merged 2 commits into from
May 3, 2023

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Apr 28, 2023

Fixes a TypeError: offlineInterface.ready is undefined error in "no-SW conditions" like private browsing in Firefox or in insecure contexts (like HTTP)

Fixes https://dhis2.atlassian.net/browse/LIBS-499

@KaiVandivier KaiVandivier requested a review from a team April 28, 2023 14:11
@KaiVandivier KaiVandivier changed the title fix(pwa): avoid crashing when SW is not available fix(pwa): avoid crashing when SW is not available [LIBS-499] May 3, 2023
@KaiVandivier KaiVandivier merged commit b681022 into master May 3, 2023
@KaiVandivier KaiVandivier deleted the libs-315-fix-no-sw-condition branch May 3, 2023 09:19
dhis2-bot added a commit that referenced this pull request May 3, 2023
## [10.3.8](v10.3.7...v10.3.8) (2023-05-03)

### Bug Fixes

* **pwa:** avoid crashing when SW is not available [LIBS-499] ([#807](#807)) ([b681022](b681022))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Aug 10, 2023
# [10.4.0-alpha.3](v10.4.0-alpha.2...v10.4.0-alpha.3) (2023-08-10)

### Bug Fixes

* move precache route to reenable navigation handler on login redirects [LIBS-473] ([#809](#809)) ([1ff29b6](1ff29b6))
* **pwa:** avoid crashing when SW is not available [LIBS-499] ([#807](#807)) ([b681022](b681022))
* omit `moment-locales` from precache ([#806](#806)) ([c8d5494](c8d5494))
* **cli:** fix envs to fix plugins in dev ([#799](#799)) ([ba29cea](ba29cea))
* **plugins:** omit launch paths when unused [LIBS-477] ([#791](#791)) ([e49a51f](e49a51f))
* **pwa:** bump ui version for headerbar connection status [LIBS-315] ([#797](#797)) ([61ff0a4](61ff0a4))
* make loading placeholders transparent ([#795](#795)) ([6e64756](6e64756))
* **plugins:** inject precache manifest correctly ([#792](#792)) ([c0d172e](c0d172e))
* **pwa:** add config option to omit files from precache [LIBS-482] ([#793](#793)) ([d089dda](d089dda))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.4.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants