Skip to content

Commit

Permalink
fix: do not automatically extend eslint configuration
Browse files Browse the repository at this point in the history
Since ESLint changed their plugin resolution mechanisms for ESLint 6 and
after upgrading to ESLint 6 in cli-style 7, this changes fixes the
problem where `cli-app-scripts build` fails for apps that use
cli-style.

Since we manually extend the existing ESLint configuration from the
project in the shell ESLint configuration, and all dependencies are
hoisted, we can avoid leveraging ESLint's internal module resolution
which is based on CWD (project/.d2/shell).
  • Loading branch information
varl committed Oct 30, 2020
1 parent 3fe0885 commit 3edcce2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shell/.env
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
SKIP_PREFLIGHT_CHECK=true
EXTEND_ESLINT=true
EXTEND_ESLINT=false

0 comments on commit 3edcce2

Please sign in to comment.