Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support another HTTP Proxy methods #299

Merged
merged 4 commits into from
Apr 25, 2018
Merged

Support another HTTP Proxy methods #299

merged 4 commits into from
Apr 25, 2018

Conversation

ittus
Copy link
Contributor

@ittus ittus commented Aug 30, 2017

Fix #298

@dherault
Copy link
Owner

Thank you for your PR, please consider #304

@dherault
Copy link
Owner

Hi @ittus , thank you for your PR! I'll be merging it another time after I review it more thoroughly. Thank you for your patience also <3

@Pat-rice
Copy link

Could you please validate this pull request ? I applied these changes and it works for me.
Some logs are wrong but it works.

Pat-rice pushed a commit to Pat-rice/serverless-offline that referenced this pull request Jan 17, 2018
…t#299 but not applied in main repo, so had to clone it
@andrewgadziksonos
Copy link

My team is also interested in this fix. Could someone take a look at it. Can confirm it works.

@ansraliant
Copy link
Contributor

The code looks good to me. However, many changes have been introduced since 2017. Could you rebase the master branch and test if it stills works?
Thank you, and sorry for the delay, just now I have some time to start reviewing stuff haha.

@ittus
Copy link
Contributor Author

ittus commented Apr 23, 2018

@ansraliant I've rebased and checked on my personal project. Everything is working as expected.

@ansraliant
Copy link
Contributor

It looks good to me. I think one of the maintainers can merge it.

@daniel-cottone daniel-cottone merged commit fff8d75 into dherault:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants