Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added claims field to authorizer requestContext for lambdaProxyContex… #292

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

ppasmanik
Copy link
Contributor

…t populated with decoded payload from JWT token if Authorization header is spedified to allow testing lambda logic that is based on claims from the token

This pull request addresses issue #264

…t populated with decoded payload from JWT token if Authorization header is spedified to allow testing lambda logic that is based on claims from the token
@dherault
Copy link
Owner

Thank you for your PR, please consider #304

@dherault dherault merged commit 1fe35d4 into dherault:master Sep 18, 2017
@dherault
Copy link
Owner

Thank you for your contribution! v3.16.0

@fubar
Copy link

fubar commented Mar 3, 2018

Thanks for this!

@ppasmanik The authorization header check is case-sensitive (it requires "Authorization") and does not kick in when a lower-case header ("authorization") is present. Both are valid as per HTTP specs and the various HTTP client libraries out there use either variation.

In the spirit of making local environments as similar to production as possible, my expectation was that unauthenticated requests would be blocked in the same way that API Gateway does. I don't currently have the time to contribute here, but thought I'd share my thoughts anyways.

@horyd
Copy link
Contributor

horyd commented Mar 17, 2018

I am having this problem now as mentioned by @fubar, I'm unable for some reason to get that header into title case, it is always being sent in lowercase and as such is not being picked up. The PR #295 seems to be looking at this same concern by with regards to content-type.

Either way, created #376 as this is currently a blocker for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants