Enable support for cron schedules #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffmanningcleartrace
force-pushed
the
gm/enable-cron
branch
from
90f2966 to
889a0aa
Compare
bfaulk96
approved these changes
Apr 21, 2022
|
@bfaulk96 Thanks for the review! Do you have any ballpark timeline of when this may get merged and versioned? I would do so myself but i lack |
|
I wish I could merge for you, but as you noted, I cannot. I did look over it though, was hoping that my approval would encourage the actual maintainers to give it a look 😅 |
abhishek-ws
approved these changes
Apr 26, 2022
bernardomafra74
approved these changes
Apr 28, 2022
giovanijfc
approved these changes
Apr 28, 2022
rodrigoSR
approved these changes
Apr 28, 2022
Jhonni-Pinto
approved these changes
Apr 28, 2022
dnalborczyk
approved these changes
May 11, 2022
|
released as part of v8.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply enable the cron support that was disabled. It works, why not use it?
If there is an edge case it doesn't work for, then let's create an issue for it,
and i will gladly fix that.
In any case, for what is essentially a mocked dev environment, it's better to be able to
work for 90% of the use cases than none of them, and so far i haven't
been able to find any problems with it in my local development.
Motivation and Context
Need to test lambda functions w/ cron schedules
Please see issue: #1044
How Has This Been Tested?
Was able to successfully run cron schedules locally