Fix referentially opaque Prelude test #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deleted test causes the Prelude to fail when imported remotely due to failing the referential sanity check. The right solution here is to make `missing` a valid transitive import for remote imports, but this is a quick fix to restore Prelude functionality until then.
sjakobi
approved these changes
Oct 21, 2019
akshaymankar
pushed a commit
to akshaymankar/dhall-concourse
that referenced
this pull request
Oct 21, 2019
* No need to specially depend on JSON type * Use grabriel/fix_Prelude untile this is merged dhall-lang/dhall-lang#781
|
@f-f @singpolyma: Could you review this quickly when you have the chance? This breaks |
|
Can we get a release of this one? :) |
|
@amarrella: I think it's a case of where the contributing process is ambiguous here: it doesn't specify if a change requires a unanimous vote or a majority vote to be merged early (i.e. after 3 days). I have always been interpreting it to mean a unanimous vote (at least, for my own contributions), but if people don't object I can relax it to a majority vote and go ahead and merge. |
|
@Gabriel439: No worries, I'm happy to wait the 3 days, I'm just using this to warm a cache so no need to relax the rules :) |
singpolyma
approved these changes
Oct 26, 2019
Merged
Gabriella439
added a commit
that referenced
this pull request
Nov 2, 2019
This reverts commit 150e82c.
TristanCacqueray
pushed a commit
to TristanCacqueray/dhall-lang
that referenced
this pull request
Jan 4, 2025
A refactor of the Nix build accidentally removed the `-Werror` flag, which caused some warnings to get past CI. This change fixes that and removes the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deleted test causes the Prelude to fail when imported remotely
due to failing the referential sanity check.
The right solution here is to make
missinga valid transitive importfor remote imports, but this is a quick fix to restore Prelude
functionality until then.