Fix decoding of imports #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #402 ... as caught by @singpolyma This fixes the decoding logic for imports to match the encoding logic. The decoding logic was missing an expected `null` field when a URL import had no custom headers.
f-f
approved these changes
Mar 5, 2019
TristanCacqueray
pushed a commit
to TristanCacqueray/dhall-lang
that referenced
this pull request
Jan 4, 2025
This adds back the missing tests for `List/indexed` (and fixes the test failures)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #402
... as caught by @singpolyma
This fixes the decoding logic for imports to match the encoding logic.
The decoding logic was missing an expected
nullfield when a URL importhad no custom headers.