Version 3.0.0 → 4.0.0 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there are some in-flight pull requests that I will wait for before cutting this release. Specifically: |
Profpatsch
reviewed
Nov 21, 2018
| ``` | ||
|
|
||
| ```haskell | ||
| https://example.com/foo/"bar?baz"?qux |
There was a problem hiding this comment.
How to escape " in this case? Just use the percent-encoding for that I assume. Can you use percent-encoding inside of quoted strings?
There was a problem hiding this comment.
@Profpatsch: It's not possible to use " within a quoted path yet. If you want to support that then we'll have to standardize it
Quoting a percent-encoded path will not work because it will percent-encode the % symbol when resolving the URL 🙂
TristanCacqueray
pushed a commit
to TristanCacqueray/dhall-lang
that referenced
this pull request
Jan 4, 2025
This fixes the root cause of e24b3d9 so that we no longer need the workaround of using `Pretty.Text.renderIO`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.