dhall-openapi: support signed openapi integers #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI intgeger types are signed, but they are currently decoded into the Dhall Natural type, which is unsigned. This PR updates the bheaviour to decode into Dhall Integers.
|
@WillSewell: Would it be possible to still use |
WillSewell
force-pushed
the
support-openapi-signed-ints
branch
from
bee31a1 to
77da9c3
Compare
|
Good point - I've pushed a PoC. I still need to test it out though. |
WillSewell
force-pushed
the
support-openapi-signed-ints
branch
from
77da9c3 to
37937f9
Compare
|
@Gabriel439 I think the most recent commit is correct. Unfortunately the kubernetes OpenAPI spec does not use |
|
@WillSewell: Thank you! Yeah, it's fine if the |
WillSewell
added a commit
to dhall-lang/dhall-kubernetes
that referenced
this pull request
Jan 17, 2021
Includes changes from dhall-lang/dhall-haskell#2126 and dhall-lang/dhall-haskell#2137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI integer types are signed (see
integer), but they are currently decoded into the Dhall Natural type, which is unsigned. This PR updates the behaviour to decode into Dhall Integers.