Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR]Adding patch to fix enhanced capability turned on for interface #44

Closed
wants to merge 1 commit into from

Conversation

dgsudharsan
Copy link
Owner

@dgsudharsan dgsudharsan commented Oct 18, 2022

Why I did it

Fixing issue

https://github.com/FRRouting/frr/issues/11108

For interface based peers with peer-groups, "no neighbor capability extended-nexthop" gets added by default. This will result in IPv4 routes not having ipv6 next hops.

How I did it

Porting the commit 8e89adc1edfb4200843e1cbbff1404172bebd9e5 to FRR 8.2.2 which fixes the issue

How to verify it

Load FRR and verify if the "no neighbor capability extended-nexthop" not gets added for interfaces associated with peer-groups

Before fix

show running-config
Building configuration...

Current configuration:
!
frr version 8.2.2
frr defaults traditional
hostname r-lionfish-16
no service integrated-vtysh-config
!
router bgp 65001
 no bgp suppress-duplicates
 neighbor PEER_V6 peer-group
 neighbor PEER_V6 remote-as internal
 neighbor PEER_V6 capability extended-nexthop
 neighbor Ethernet116 interface peer-group PEER_V6
 no neighbor Ethernet116 capability extended-nexthop
 !
 address-family ipv4 unicast
  redistribute connected
 exit-address-family
 !
exit

After fix

show running-config
Building configuration...

Current configuration:
!
frr version 8.2.2
frr defaults traditional
hostname r-lionfish-16
no service integrated-vtysh-config
!
router bgp 65001
 no bgp suppress-duplicates
 neighbor PEER_V6 peer-group
 neighbor PEER_V6 remote-as internal
 neighbor PEER_V6 capability extended-nexthop
 neighbor Ethernet116 interface peer-group PEER_V6
 !
 address-family ipv4 unicast
  redistribute connected
 exit-address-family
 !
exit

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan dgsudharsan deleted the frr_patch_1 branch March 9, 2023 01:51
dgsudharsan pushed a commit that referenced this pull request Nov 14, 2023
…ly (sonic-net#17140)

#### Why I did it
src/dhcprelay
```
* 40c6877 - (HEAD -> master, origin/master, origin/HEAD) [CodeQL] fix unmet dependency for `build-swss-common` (#44) (30 hours ago) [Jing Zhang]
```
#### How I did it
#### How to verify it
#### Description for the changelog
dgsudharsan pushed a commit that referenced this pull request Jan 26, 2024
sonic-dhcp-relay
5ae186f Yaqiang Zhu Tue Dec 19 12:05:15 2023 -0500 [counter] Clear counter table when init (#45)
40c6877 Jing Zhang Fri Nov 10 12:41:23 2023 -0800 [CodeQL] fix unmet dependency for build-swss-common (#44)

sonic-dhcpmon
7c55e50 StormLiangMS Thu Sep 14 09:57:06 2023 +0800 Merge pull request #13 from jcaiMR/dev/jcai_master_interface_counter
085a087 jcaiMR Mon Sep 11 09:17:03 2023 +0000 refine counting logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants