This repository has been archived by the owner on May 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this. There are a lot of changes in this pull request. It might take me a bit to review. |
2 years later... You weren't kidding! 😄 |
Lol. I don't really know what to do with this PR. The commit comments aren't helpful and there aren't, as far as I can tell, functional changes. Have you looked through this, @porjo? |
I don't think I can land this for the following reasons:
I'd be happy to address these changes in more detail as individual pull requests. |
Waterdrips
pushed a commit
to Waterdrips/jwt-go
that referenced
this pull request
Sep 14, 2020
…codeowners-1600076031644796752 [skip ci] Adding CODEOWNERS file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've made the code a little cleaner and a little easier to read. In addition, i've it wrote so that signing strings runs concurrently. This will improve its performance.