Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tree from stealing focus from the page (for Issue #142) #143

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Prevent tree from stealing focus from the page (for Issue #142) #143

merged 4 commits into from
Jan 12, 2024

Conversation

Sappharad
Copy link
Contributor

  • If the user is not interacting directly with the tree already, it should not be able to scroll itself into view or take over focus when it is being controlled by something else on the page.
  • In situations like a master + details view where the tree is the details and the master control changes what is selected in the tree, the tree should not steal focus from the other control whose actions were modifying it. Such as if a user is arrowing through a list at the top of the page and there is a tree below it.

Related issue:
#142

@stale
Copy link

stale bot commented Oct 30, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2023
@stale stale bot removed the wontfix This will not be worked on label Oct 30, 2023
@stale Stale
Copy link

stale bot commented Dec 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 29, 2023
@Sappharad
Prevent tree from stealing focus from the page
8359d2a 
- If the user is not interacting directly with the tree already, it should not be able to scroll itself into view or take over focus when it is being controlled by something else on the page.
- In situations like a master + details view where the tree is the details and the master control changes what is selected in the tree, the tree should not steal focus from the other control whose actions were modifying it. Such as if a user is arrowing through a list at the top of the page and there is a tree below it.
@Sappharad
Grammatical failure
3983bea
@Sappharad
Resolve linter complaints
b5e42c0
@stale stale bot removed the wontfix This will not be worked on label Dec 29, 2023
@yhy-1
Copy link
Collaborator

yhy-1 commented Jan 12, 2024

LGTM

@yhy-1 yhy-1 merged commit 4e82bb3 into dgreene1:master Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhy-1 yhy-1 yhy-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sappharad @yhy-1