Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Readme): Use new Wait method #327

Merged
merged 1 commit into from
Mar 21, 2023
Merged

docs(Readme): Use new Wait method #327

merged 1 commit into from
Mar 21, 2023

Conversation

angadn
Copy link
Contributor

@angadn angadn commented Jan 16, 2023

Problem

README was using a time.Sleep in its example

Solution

PR updates it to use the new Wait() method.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 merged commit 3177d9c into dgraph-io:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angadn @CLAassistant @mangalaman93