Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rely on cache.Wait() instead of time.Sleep() #280

Merged
merged 1 commit into from
Jun 13, 2021
Merged

doc: rely on cache.Wait() instead of time.Sleep() #280

merged 1 commit into from
Jun 13, 2021

Conversation

CamiloGarciaLaRotta
Copy link

@CamiloGarciaLaRotta CamiloGarciaLaRotta commented Jun 7, 2021 •
edited by manishrjain
Loading

👋🏽 hi all

What

Now that #184 has landed, we can update the docs to rely on cache.Wait() instead of time.Sleep().

Rollout Risk: none

Doc only PR, no production code changes

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jarifibrahim
Copy link
Contributor

cc @ahsanbarkati @NamanJain8

@NamanJain8 NamanJain8 merged commit 01b9f37 into dgraph-io:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CamiloGarciaLaRotta @CLAassistant @jarifibrahim @NamanJain8