Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move SuperFlag to Ristretto #246

Merged
merged 1 commit into from
Feb 5, 2021
Merged

move SuperFlag to Ristretto #246

merged 1 commit into from
Feb 5, 2021

Conversation

karlmcguire
Copy link
Contributor

@karlmcguire karlmcguire commented Feb 3, 2021 •
edited
Loading

(This relates to DGRAPH-3003 and is blocking dgraph-io/dgraph#7393.)

For use within Dgraph and Badger, we moved the SuperFlag struct and tests to Ristretto to avoid import cycles.

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@karlmcguire karlmcguire mentioned this pull request Feb 3, 2021
Merged
@manishrjain
Copy link
Contributor

approved.

@karlmcguire karlmcguire merged commit 1fb8d28 into master Feb 5, 2021
@karlmcguire karlmcguire deleted the karl/flags branch February 5, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@manishrjain manishrjain Awaiting requested review from manishrjain

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlmcguire @CLAassistant @manishrjain