Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(allocator): make nil allocator return go byte slice #217

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix(allocator): make nil allocator return go byte slice #217

merged 1 commit into from
Nov 4, 2020

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Nov 4, 2020 •
edited by manishrjain
Loading

This PR makes nil allocator return a go byte slice. It was removed in this commit.
At places, in dgraph (e.g kvs, err := l.Rollup(nil)) we are using nil allocator, and hence causes panic there.

This change is Reviewable

ahsanbarkati
ahsanbarkati approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@ahsanbarkati ahsanbarkati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NamanJain8 NamanJain8 merged commit 732f879 into master Nov 4, 2020
@NamanJain8 NamanJain8 deleted the naman/allocator branch November 4, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@manishrjain manishrjain Awaiting requested review from manishrjain

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @ahsanbarkati